MTV-2039 | Allow to specify the diskBus #1333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaacov
reviewed
Feb 4, 2025
mnecas
force-pushed
the
MTV-1635
branch
2 times, most recently
from
7b23787 to
5395b30
Compare
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1333 +/- ##
==========================================
- Coverage 15.45% 15.44% -0.02%
==========================================
Files 112 112
Lines 23377 23393 +16
==========================================
Hits 3613 3613
- Misses 19479 19495 +16
Partials 285 285
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Allow users to specify the plan.spec.diskBus which will set it on all disks during the creation. Possible options 'scsi', 'sata' and 'virtio'. Ref: https://issues.redhat.com/browse/MTV-1635 Signed-off-by: Martin Necas <[email protected]>
|
Merged
mnecas
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow users to specify the
plan.spec.diskBuswhich will set it on all disks during the creation.Possible options 'scsi', 'sata' and 'virtio'.
Ref: https://issues.redhat.com/browse/MTV-1635